Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-729. Blank Page after redirect#508

Closed
kobe860219 wants to merge 1 commit intoapache:masterfrom
kobe860219:SUBMARINE-729
Closed

SUBMARINE-729. Blank Page after redirect#508
kobe860219 wants to merge 1 commit intoapache:masterfrom
kobe860219:SUBMARINE-729

Conversation

@kobe860219
Copy link
Copy Markdown
Contributor

What is this PR for?

Fix the problem of redirecting to a blank page when clicking the submarine icon on the workbench.
Now it will redirect to experiment page.

What type of PR is it?

[Bug Fix]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-729

How should this be tested?

https://travis-ci.org/github/kobe860219/submarine/builds/757821165

Screenshots (if appropriate)

SUBMARINE-729

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions?No
  • Does this needs documentation? No

Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, Thanks @kobe860219

@ByronHsu
Copy link
Copy Markdown
Member

ByronHsu commented Feb 7, 2021

LGTM

@asfgit asfgit closed this in feff4c1 Feb 7, 2021
ByronHsu pushed a commit to ByronHsu/submarine that referenced this pull request Feb 17, 2021
### What is this PR for?
Fix the problem of redirecting to a blank page when clicking the submarine icon on the workbench.
Now it will redirect to experiment page.

### What type of PR is it?
[Bug Fix]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-729

### How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/757821165

### Screenshots (if appropriate)
![SUBMARINE-729](https://user-images.githubusercontent.com/48027290/107121636-82168e00-68ce-11eb-9732-81b914ebb6b7.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions?No
* Does this needs documentation? No

Author: kobe860219 <kobe860219@gmail.com>

Signed-off-by: Kevin <pingsutw@apache.org>

Closes apache#508 from kobe860219/SUBMARINE-729 and squashes the following commits:

65f376f [kobe860219] SUBMARINE-729. Blank Page after redirect
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants