Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-750. Replace port 8080 with port 32080 in API example#524

Merged
kevin85421 merged 2 commits intoapache:masterfrom
jeff-901:SUBMARINE-750
Mar 3, 2021
Merged

SUBMARINE-750. Replace port 8080 with port 32080 in API example#524
kevin85421 merged 2 commits intoapache:masterfrom
jeff-901:SUBMARINE-750

Conversation

@jeff-901
Copy link
Copy Markdown
Contributor

What is this PR for?

Update API documents.

What type of PR is it?

[Documentation]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-750

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@kevin85421 kevin85421 self-requested a review February 28, 2021 07:28
@kevin85421
Copy link
Copy Markdown
Member

@jeff-901 Thank you for your contribution! I have some recommendations for your pull request title.

The pull request title must follow the following format:

SUBMARINE-${jira_number}. ${jira_summary}

e.g.

SUBMARINE-750. Replace port 8080 with port 32080 in API example

With the correct pull request title, JIRA can link this pull request automatically.

@jeff-901 jeff-901 changed the title Submarine 750 SUBMARINE-750. Replace port 8080 with port 32080 in API example Mar 1, 2021
@ByronHsu
Copy link
Copy Markdown
Member

ByronHsu commented Mar 2, 2021

LGTM

@kevin85421 kevin85421 merged commit b2facbc into apache:master Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants