Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-784. Grammar fixes#547

Closed
fredster33 wants to merge 3 commits intomasterfrom
unknown repository
Closed

SUBMARINE-784. Grammar fixes#547
fredster33 wants to merge 3 commits intomasterfrom
unknown repository

Conversation

@fredster33
Copy link
Copy Markdown
Contributor

@fredster33 fredster33 commented Mar 30, 2021 •
edited by xunliu
Loading

What is this PR for?

A few minor grammar fixes for the README and pull request template.

What type of PR is it?

Documentation

Todos

None

What is the Jira issue?

https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-784

How should this be tested?

No tests applicable.

Screenshots (if appropriate)

N/A

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

xunliu
xunliu approved these changes Mar 31, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredster33 Thank you fixed this typo. :-)
Please submit your changes in accordance with our specifications. http://submarine.apache.org/docs/community/contributing

@pingsutw
Copy link
Copy Markdown
Member

pingsutw commented Apr 5, 2021

@fredster33 could you create a JIRA ticket in the https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE ?

@fredster33
Copy link
Copy Markdown
Contributor Author

fredster33 commented Apr 5, 2021

@fredster33 could you create a JIRA ticket in the https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE ?

Will do, okay.

@fredster33
Copy link
Copy Markdown
Contributor Author

fredster33 commented Apr 5, 2021

Got it, it is available at https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-784.

@fredster33 fredster33 changed the title Grammar fixes SUBMARINE-784. Grammar fixes Apr 5, 2021
xunliu
xunliu approved these changes Apr 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge if no more comments.

@asfgit asfgit closed this in 3cb2ecd Apr 13, 2021
@xunliu
Copy link
Copy Markdown
Member

xunliu commented Apr 13, 2021

@fredster33 Thank you for your contribution.
I have set up JIRA permission for you, next time, you can create jira and assign it to youself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@xunliu xunliu xunliu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fredster33 @pingsutw @xunliu