This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-814. Install local pytorchjob chart via helm golang API#577
Merged
kevin85421 merged 1 commit intoapache:masterfrom May 9, 2021
Merged
SUBMARINE-814. Install local pytorchjob chart via helm golang API#577kevin85421 merged 1 commit intoapache:masterfrom
kevin85421 merged 1 commit intoapache:masterfrom
Conversation
xunliu
reviewed
May 3, 2021
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
@Kenchu123 Please fixed conflicts. Thanks.
Kenchu123
force-pushed
the
SUBMARINE-814
branch
2 times, most recently
from
36e2731 to
c5ba3fd
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
pytorch chart:
https://github.com/apache/submarine/tree/master/helm-charts/submarine/charts/pytorchjob
Helm golang API:
https://github.com/apache/submarine/blob/master/submarine-cloud-v2/pkg/helm/helm.go
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-814
How should this be tested?
https://www.travis-ci.com/github/Kenchu123/submarine/builds/224734346
Screenshots (if appropriate)
By operator:
helm
pods
deployments
services
replicaset
Questions: