This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-813. Add mock test to pysubmarine models.#579
Merged
kobe860219 merged 18 commits intoapache:masterfrom May 10, 2021
Merged
SUBMARINE-813. Add mock test to pysubmarine models.#579kobe860219 merged 18 commits intoapache:masterfrom
kobe860219 merged 18 commits intoapache:masterfrom
Conversation
jojochuang
reviewed
May 4, 2021
| # TODO: Setup cluster by helm in CI/CD to enable mlflow server connection | ||
| # TODO: Set an cooldown time between each test case | ||
| @pytest.mark.skip(reason="no way of currently testing this") | ||
| # @pytest.mark.skip(reason="no way of currently testing this") |
Contributor
There was a problem hiding this comment.
If this annotation no longer applies, please remove it entirely.
### What is this PR for? Install local notebook-controller chart via Helm golang API. tfjob chart: https://github.com/apache/submarine/tree/master/helm-charts/submarine/charts/tfjob Helm golang API: https://github.com/apache/submarine/blob/master/submarine-cloud-v2/pkg/helm/helm.go ### What type of PR is it? Feature ### Todos ### What is the Jira issue? https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-812 ### How should this be tested? https://travis-ci.org/github/noidname01/submarine/builds/769329103 --> ### Screenshots (if appropriate) Helm install  In-cluster operator  ### Questions: * Do the license files need updating? No * Are there breaking changes for older versions? No * Does this need new documentation? No Author: noidname01 <tim983649@gmail.com> Signed-off-by: Liu Xun <liuxun@apache.org> Closes apache#578 from noidname01/SUBMARINE-812 and squashes the following commits: 4797fce [noidname01] SUBMARINE-812. Install local tfjob chart via helm golang API
ByronHsu
reviewed
May 7, 2021
| from submarine import ModelsClient | ||
|
|
||
|
|
||
| # Temporarily skip these tests after the following is solved: |
Member
There was a problem hiding this comment.
These three lines can be removed too
…into SUBMARINE-813
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add mock test to new pysubmarine feature -- model management.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-813
How should this be tested?
Screenshots (if appropriate)
Questions: