Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-817. Add model management e2e test#581

Merged
kobe860219 merged 5 commits intoapache:masterfrom
ByronHsu:ga
May 10, 2021
Merged

SUBMARINE-817. Add model management e2e test#581
kobe860219 merged 5 commits intoapache:masterfrom
ByronHsu:ga

Conversation

@ByronHsu
Copy link
Copy Markdown
Member

@ByronHsu ByronHsu commented May 7, 2021

What is this PR for?

  1. Forward mlflow and minio port for testing.
  2. Add model management e2e test

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-817

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@ByronHsu
Copy link
Copy Markdown
Member Author

ByronHsu commented May 7, 2021

@jeff-901 @kobe860219 Help me review the code. Thanks!

@jeff-901
Copy link
Copy Markdown
Contributor

jeff-901 commented May 8, 2021

@jeff-901 @kobe860219 Help me review the code. Thanks!

LGTM

@kobe860219
Copy link
Copy Markdown
Contributor

LGTM. Thanks @ByronHsu your contribution! Some test is failed, is it need to fix?

@ByronHsu
Copy link
Copy Markdown
Member Author

@kobe860219 No, they have been fixed in #582.

@kobe860219 kobe860219 merged commit 17ffc4e into apache:master May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants