SUBMARINE-835. Exposing method modified#598
Conversation
|
|
||
| # Step4: View workbench (127.0.0.1:32080) with your web browser | ||
| # Step4: View workbench | ||
| # http://{minikube ip}:32080, ex: http://192.168.49.2:32080 |
There was a problem hiding this comment.
In my experience, minikube ip does not work in the development environment (MacOS), and thus it would be better to add method2 (port-forward command).
There was a problem hiding this comment.
In the following figure, the branch is at commit "SUBMARINE-841. Modify hard-coded URLs in E2E test to soft-coded URLs".
There was a problem hiding this comment.
It seems that you miss the url to expose, but I don't know what's the reason.
I will add method2 to make sure everyone can access to the service.
| // (2) Basic operations: on/off/modify (change port) | ||
| // (3) in-cluster | ||
| if action == ADD { | ||
| if !c.incluster { |
There was a problem hiding this comment.
Do you have tested the deletion of submarine CR? I guess that the deletion will have some bugs.
There was a problem hiding this comment.
Oh I found that there's something I didn't notice, I'll fix it ASAP.
2 participants
What is this PR for?
Modify the way to access Submarine in a cluster in documentation.
What type of PR is it?
[Improvement|Documentation]
Todos
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-835
How should this be tested?
Screenshots (if appropriate)
2021-06-04.22_49_12.mp4
Questions: