This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-845. Fix submarine-server test->ClusterRestApiTest->testGetClusterNode#599
Closed
KUAN-HSUN-LI wants to merge 2 commits intoapache:masterfrom
Closed
SUBMARINE-845. Fix submarine-server test->ClusterRestApiTest->testGetClusterNode#599KUAN-HSUN-LI wants to merge 2 commits intoapache:masterfrom
KUAN-HSUN-LI wants to merge 2 commits intoapache:masterfrom
Conversation
xunliu
reviewed
Jun 5, 2021
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
Hi,
I was thinking, the cluster function may increase the complexity of the system?
Should I temporarily shield this module?
how do you feel?
xunliu
reviewed
Jun 10, 2021
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
@KUAN-HSUN-LI I see that Travis CI is failed, Please trigger Travis, Thanks.
xunliu
approved these changes
Jun 18, 2021
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
@KUAN-HSUN-LI Thank you for your fixed this issue.
LGTM
Will merge if no more comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
ISO DATE TIME FORMAT will remove the last 0 in the DateTime object (ex: XXX-XXX-XXX0 -> XXX-XXX-XXX), but DateTime object to string will keep the origin format (ex: XXX-XXX-XXX0 -> XXX-XXX-XXX0)
Solved by using the same formatter.
What type of PR is it?
[CI/CD]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-845
How should this be tested?
Screenshots (if appropriate)
Questions: