This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-881. Sidebar page component object for e2e-test#625
Closed
noidname01 wants to merge 10 commits intoapache:masterfrom
Closed
SUBMARINE-881. Sidebar page component object for e2e-test#625noidname01 wants to merge 10 commits intoapache:masterfrom
noidname01 wants to merge 10 commits intoapache:masterfrom
Conversation
Contributor
Author
kevin85421
suggested changes
Jun 30, 2021
Member
kevin85421
left a comment
kevin85421
left a comment
There was a problem hiding this comment.
@noidname01 Thank you for your contribution! There are some recommendatinos.
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/datadictIT.java
Outdated
Show resolved
Hide resolved
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/workspaceIT.java
Outdated
Show resolved
Hide resolved
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/components/Sidebars.java
Outdated
Show resolved
Hide resolved
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/components/Sidebars.java
Outdated
Show resolved
Hide resolved
kevin85421
reviewed
Jun 30, 2021
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/components/Sidebars.java
Outdated
Show resolved
Hide resolved
kevin85421
reviewed
Jul 1, 2021
|
|
||
| public class Sidebars extends AbstractSubmarineIT{ | ||
|
|
||
| private String URL = getURL("http://127.0.0.1", 8080); |
Member
There was a problem hiding this comment.
In my opinion, it is better to pass URL as a function argument. Any thoughts?
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/dataIT.java
Show resolved
Hide resolved
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/departmentIT.java
Show resolved
Hide resolved
| public void workspaceNavigation() throws Exception { | ||
| String URL = getURL("http://127.0.0.1", 8080); | ||
| // Login | ||
|
|
| public void notebookNavigation() throws Exception { | ||
| String URL = getURL("http://127.0.0.1", 8080); | ||
| // Login | ||
|
|
| @Test | ||
| public void workspaceNavigation() throws Exception { | ||
| String URL = getURL("http://127.0.0.1", 8080); | ||
|
|
kevin85421
suggested changes
Jul 2, 2021
| ExperimentPage experimentPage = new ExperimentPage(driver); | ||
| // Login | ||
| Sidebars sidebars = new Sidebars(URL); | ||
| // Login |
| String URL = getURL("http://127.0.0.1", 8080); | ||
| // Login | ||
| Sidebars sidebars = new Sidebars(URL); | ||
| // Login |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Sidebar page component object for e2e-test
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-881
How should this be tested?
Screenshots (if appropriate)
Questions: