-
Notifications
You must be signed in to change notification settings - Fork 252
SUBMARINE-928. [Quickstart] Rewrite quickstart guide #664
Conversation
|
@pingsutw @kevin85421 Need suggestions! Thanks! |
kevin85421
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @ByronHsu for your contribution! This document will be helpful for Submarine community development.
|
TODO: 1. trim the memory limit 2. add mlflow demo |
pingsutw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
| set -euxo pipefail | ||
|
|
||
| SUBMARINE_VERSION=0.6.0-SNAPSHOT | ||
| SUBMARINE_IMAGE_NAME="quickstart:${SUBMARINE_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be changed to apache/submarine:quickstart-${SUBMARINE_VERSION},
and we could build the image and deploy it to the submarine docker hub.
https://github.com/apache/submarine/blob/master/.github/workflows/deploy_docker_images.yml
|
@ByronHsu Could you fix the conflict? Thanks!! |
What is this PR for?
Write an example that will walk users through the end-to-end usage of the submarine.
What type of PR is it?
[Documentation]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-928
How should this be tested?
Screenshots (if appropriate)
Questions: