Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

Conversation

@ByronHsu
Copy link
Member

What is this PR for?

Write an example that will walk users through the end-to-end usage of the submarine.

What type of PR is it?

[Documentation]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-928

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@ByronHsu
Copy link
Member Author

@pingsutw @kevin85421 Need suggestions! Thanks!

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @ByronHsu for your contribution! This document will be helpful for Submarine community development.

@ByronHsu
Copy link
Member Author

TODO: 1. trim the memory limit 2. add mlflow demo

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

set -euxo pipefail

SUBMARINE_VERSION=0.6.0-SNAPSHOT
SUBMARINE_IMAGE_NAME="quickstart:${SUBMARINE_VERSION}"
Copy link
Member

@pingsutw pingsutw Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be changed to apache/submarine:quickstart-${SUBMARINE_VERSION},
and we could build the image and deploy it to the submarine docker hub.
https://github.com/apache/submarine/blob/master/.github/workflows/deploy_docker_images.yml

@pingsutw
Copy link
Member

@ByronHsu Could you fix the conflict? Thanks!!

@asfgit asfgit closed this in a94494b Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants