This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-935. Support test-k8s on both KinD and minikube#668
Closed
KUAN-HSUN-LI wants to merge 2 commits intoapache:masterfrom
Closed
SUBMARINE-935. Support test-k8s on both KinD and minikube#668KUAN-HSUN-LI wants to merge 2 commits intoapache:masterfrom
KUAN-HSUN-LI wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
@kevin85421 Can you help me review this PR. Thanks in advance! |
kevin85421
reviewed
Jul 15, 2021
Member
kevin85421
left a comment
kevin85421
left a comment
There was a problem hiding this comment.
It looks good to me. Can you add a screenshot about running test-k8s with minikube? In addition, add a hyperlink to IntegrationTestK8s.md.
KUAN-HSUN-LI
force-pushed
the
SUBMARINE-935
branch
from
302d0e9 to
c4dba22
Compare
Member
Author
|
@kevin85421 Thanks for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Support running the test-k8s on both KinD and minikube
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-935
How should this be tested?
KinD is tested in CI.
minikube should be tested following the document
Screenshots (if appropriate)
Questions: