This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-955. Add Limit on Experiment Name #692
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
reviewed
Aug 5, 2021
Member
kevin85421
left a comment
kevin85421
left a comment
There was a problem hiding this comment.
In addition, I am not familiar with regex, but we can discuss the regex with @MortalHappiness in today's meeting.
...ment-home/experiment-form/experiment-predefined-form/experiment-predefined-form.component.ts
Show resolved
Hide resolved
...ment-home/experiment-form/experiment-predefined-form/experiment-predefined-form.component.ts
Outdated
Show resolved
Hide resolved
...nt-home/experiment-form/experiment-predefined-form/experiment-predefined-form.component.scss
Outdated
Show resolved
Hide resolved
...nt-home/experiment-form/experiment-customized-form/experiment-customized-form.component.html
Outdated
Show resolved
Hide resolved
noidname01
force-pushed
the
SUBMARINE-955
branch
from
47b55b3 to
f096c1b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Former PR has some edge case.
Like:
Valid cases are like:
So I change the pattern for validating experiment name to filter these cases.
And I also add this pattern to experiment name of predefine template.
What type of PR is it?
[Bug Fix]
Todos
None
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-955
How should this be tested?
Open the workbench and type invalid experiment name.
Screenshots (if appropriate)
invalid name on custom experiment
invalid name on predefine experiment
valid name on custom experiment
valid name on predefine experiment
Questions: