Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

Conversation

@MortalHappiness
Copy link
Member

What is this PR for?

The submarine-mlflow and submarine-database deployments are created at the same time and mlflow needs to wait for the database. Since mlflow use exponential back-off waiting, it takes a long time to be in the ready state.

What type of PR is it?

[Bug Fix]

Todos

  • - Add ReadinessProbe for submarine-database
  • - Add InitContainers for submarine-mlflow

Reference: https://kubernetes.io/docs/concepts/workloads/pods/init-containers/

What is the Jira issue?

https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1016

How should this be tested?

Screenshots (if appropriate)

Before:
Screenshot from 2021-09-07 22-22-36

After:
Screenshot from 2021-09-12 23-10-09

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 84599b3 Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants