This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-1109. Java k8s client version from 6 upgrade to 11 #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingsutw
approved these changes
Dec 9, 2021
...tter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
Outdated
Show resolved
Hide resolved
noidname01
force-pushed
the
SUBMARINE-1109
branch
from
1b8f33e to
e2d2a9c
Compare
KUAN-HSUN-LI
suggested changes
Dec 18, 2021
Member
KUAN-HSUN-LI
left a comment
KUAN-HSUN-LI
left a comment
There was a problem hiding this comment.
There were some mistakes in fixing the conflict
Comment on lines
542
to
544
| istioVirtualService.getPlural(), | ||
| istioVirtualService, | ||
| "true"); |
Member
There was a problem hiding this comment.
This is a mistake of replace istioVirtualService with seldonDeployment
Contributor
Author
There was a problem hiding this comment.
Oh, you're right. I'll fix it ASAP.
Comment on lines
576
to
582
| api.deleteNamespacedCustomObject(istioVirtualService.getGroup(), | ||
| istioVirtualService.getVersion(), | ||
| "default", | ||
| istioVirtualService.getPlural(), | ||
| istioVirtualService.getMetadata().getName(), | ||
| new V1DeleteOptionsBuilder().withApiVersion(istioVirtualService.getApiVersion()).build(), | ||
| null, null, null); |
Member
There was a problem hiding this comment.
Don't remove the istioVirtualService
Member
|
@noidname01 Some tests are failed. It seems like the import error |
Contributor
Author
Yeah I know, seems that I screw it when rebasing🥲 |
Contributor
Author
|
@KUAN-HSUN-LI fixed! |
KUAN-HSUN-LI
approved these changes
Dec 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The version of k8s client we use is almost out of date, and lacks many features, like CustomResources Management, Generic Api and more concise function.
What type of PR is it?
[Improvement]
Todos
None
What is the Jira issue?
SUBMARINE-1109. Java k8s client version from 6 upgrade to 11
How should this be tested?
None
Screenshots (if appropriate)
None
Questions: