Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1270. move surffire configuration to submodule#954

Closed
FatalLin wants to merge 22 commits intoapache:masterfrom
FatalLin:SUBMARINE-1270
Closed

SUBMARINE-1270. move surffire configuration to submodule#954
FatalLin wants to merge 22 commits intoapache:masterfrom
FatalLin:SUBMARINE-1270

Conversation

@FatalLin
Copy link
Copy Markdown
Contributor

@FatalLin FatalLin commented May 9, 2022

What is this PR for?

refer to #953, I found out the surffire didn't work if I only add the configuration in root pom.xml, so I move them to submodules.

What type of PR is it?

Bug Fix

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1270

How should this be tested?

check coverage report.

Screenshots (if appropriate)

Questions:

  • Do the license files need updating?No
  • Are there breaking changes for older versions?No
  • Does this need new documentation?No

@FatalLin FatalLin changed the title SUBMARINE-1270. move surffire configuration to submodule SUBMARINE-1270. move surffire configuration to submodule[WIP] May 9, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2022

Codecov Report

Merging #954 (8b60db8) into master (997e9ab) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #954   +/-   ##
=========================================
  Coverage     26.65%   26.65%           
  Complexity       53       53           
=========================================
  Files            34       34           
  Lines           709      709           
  Branches         57       57           
=========================================
  Hits            189      189           
  Misses          498      498           
  Partials         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997e9ab...8b60db8. Read the comment docs.

@FatalLin FatalLin changed the title SUBMARINE-1270. move surffire configuration to submodule[WIP] SUBMARINE-1270. move surffire configuration to submodule May 9, 2022
@asfgit asfgit closed this in 6a7b5fe May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant