Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1271. Submarine-cloud-v3 initialization#957

Closed
Kenchu123 wants to merge 6 commits intoapache:masterfrom
Kenchu123:SUBMARINE-1271
Closed

SUBMARINE-1271. Submarine-cloud-v3 initialization#957
Kenchu123 wants to merge 6 commits intoapache:masterfrom
Kenchu123:SUBMARINE-1271

Conversation

@Kenchu123
Copy link
Copy Markdown
Contributor

What is this PR for?

Create submarine operator with operator-sdk.

This is only the setup for future development environments.

What type of PR is it?

Feature

Todos

  • - initailize submarine-cloud-v3 with operator-sdk
  • - change types to generate submarine crd
  • - add new development doc

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1271

How should this be tested?

Follow the submarine-cloud-v3/docs/developer-guide.md

Screenshots (if appropriate)

Running operator in-cluster
Screen Shot 2022-05-15 at 9 11 55 PM

Running submarine

Screen Shot 2022-05-15 at 9 13 08 PM

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? Yes
  • Does this need new documentation? Yes

@Kenchu123
Copy link
Copy Markdown
Contributor Author

Please help review. @MortalHappiness @joshvictor1024.

@codecov
Copy link
Copy Markdown

codecov bot commented May 15, 2022

Codecov Report

Merging #957 (0c1b9be) into master (2a994f1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #957   +/-   ##
=========================================
  Coverage     26.65%   26.65%           
  Complexity       53       53           
=========================================
  Files            34       34           
  Lines           709      709           
  Branches         57       57           
=========================================
  Hits            189      189           
  Misses          498      498           
  Partials         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a994f1...0c1b9be. Read the comment docs.

@joshvictor1024
Copy link
Copy Markdown
Contributor

looks good to me.

Copy link
Copy Markdown
Member

@MortalHappiness MortalHappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 7652a0c May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants