This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-1270. add server-database's test into git hub action and extract the coverage analyze source from all jar with submarine prefix#958
Closed
FatalLin wants to merge 31 commits intoapache:masterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
=============================================
- Coverage 26.65% 11.06% -15.60%
- Complexity 53 774 +721
=============================================
Files 34 237 +203
Lines 709 24541 +23832
Branches 57 3545 +3488
=============================================
+ Hits 189 2716 +2527
- Misses 498 21653 +21155
- Partials 22 172 +150
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The coverage is still not worked since last PR, so I dig the coverage script and try to find more information.
I found out the original script only extract the class form submarine-all* jar, but a huge numbers of module's jar is put under lib directory, so all of them won't be scanned.
In the mean time, I also noticed the github action didn't execute the unit tests of submaine-database, so I add them into flow as well.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1270
How should this be tested?
should passed existed tests.
Screenshots (if appropriate)
Questions: