Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1270. add server-database's test into git hub action and extract the coverage analyze source from all jar with submarine prefix#958

Closed
FatalLin wants to merge 31 commits intoapache:masterfrom
FatalLin:SUBMARINE-1270
Closed

SUBMARINE-1270. add server-database's test into git hub action and extract the coverage analyze source from all jar with submarine prefix#958
FatalLin wants to merge 31 commits intoapache:masterfrom
FatalLin:SUBMARINE-1270

Conversation

@FatalLin
Copy link
Copy Markdown
Contributor

@FatalLin FatalLin commented May 17, 2022

What is this PR for?

The coverage is still not worked since last PR, so I dig the coverage script and try to find more information.
I found out the original script only extract the class form submarine-all* jar, but a huge numbers of module's jar is put under lib directory, so all of them won't be scanned.
In the mean time, I also noticed the github action didn't execute the unit tests of submaine-database, so I add them into flow as well.

What type of PR is it?

Improvement

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1270

How should this be tested?

should passed existed tests.

Screenshots (if appropriate)

image

Questions:

  • Do the license files need updating?No
  • Are there breaking changes for older versions?No
  • Does this need new documentation?No

@codecov
Copy link
Copy Markdown

codecov bot commented May 17, 2022

Codecov Report

Merging #958 (d8f3bba) into master (7652a0c) will decrease coverage by 15.59%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #958       +/-   ##
=============================================
- Coverage     26.65%   11.06%   -15.60%     
- Complexity       53      774      +721     
=============================================
  Files            34      237      +203     
  Lines           709    24541    +23832     
  Branches         57     3545     +3488     
=============================================
+ Hits            189     2716     +2527     
- Misses          498    21653    +21155     
- Partials         22      172      +150     
Impacted Files Coverage Δ
...marine/commons/cluster/meta/ClusterMetaEntity.java 100.00% <0.00%> (ø)
.../database/workbench/entity/ProjectFilesEntity.java 0.00% <0.00%> (ø)
.../submarine/server/api/experiment/ExperimentId.java 86.66% <0.00%> (ø)
.../submarine/server/api/spec/ExperimentTaskSpec.java 46.87% <0.00%> (ø)
...ache/submarine/commons/cluster/ClusterManager.java 87.58% <0.00%> (ø)
...a/org/apache/submarine/server/SubmarineServer.java 57.41% <0.00%> (ø)
...imenttemplate/entity/ExperimentTemplateEntity.java 100.00% <0.00%> (ø)
...e/server/utils/gson/EnvironmentIdDeserializer.java 100.00% <0.00%> (ø)
...i/experimenttemplate/ExperimentTemplateSubmit.java 28.57% <0.00%> (ø)
...rine/server/utils/gson/ExperimentIdSerializer.java 100.00% <0.00%> (ø)
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7652a0c...d8f3bba. Read the comment docs.

@FatalLin FatalLin closed this May 17, 2022
@FatalLin FatalLin reopened this May 17, 2022
@FatalLin FatalLin changed the title SUBMARINE-1270. add surffire plugin in submarine-database module SUBMARINE-1270. add server-database's test into git hub action and extract the coverage analyze source from all jar with submarine prefix May 18, 2022
Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@asfgit asfgit closed this in 673c6b7 May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants