Skip to content

Commit 02a069f

Browse files
committed
fix bito recommended
1 parent 208b351 commit 02a069f

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

superset-frontend/src/explore/components/controls/ColorPickerControl.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,10 @@ export default function ColorPickerControl({
148148
return;
149149
}
150150

151-
if (resolveThemeTokens && reverseMap[hex]) {
151+
if (
152+
resolveThemeTokens &&
153+
Object.prototype.hasOwnProperty.call(reverseMap, hex)
154+
) {
152155
onChange(reverseMap[hex]);
153156
return;
154157
}

superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.test.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,12 @@ test('renders None for operator when Green for increase is selected', async () =
135135
});
136136

137137
const presets = document.querySelectorAll('.ant-color-picker-presets-color');
138-
const greenPreset = presets[6];
138+
const greenPreset = Array.from(presets).find(preset => {
139+
const inner = preset.querySelector('.ant-color-picker-color-block-inner');
140+
return inner && inner.getAttribute('style')?.includes('0, 150, 0');
141+
});
142+
143+
expect(greenPreset).toBeInTheDocument();
139144

140145
const innerColorBlock = greenPreset.querySelector(
141146
'.ant-color-picker-color-block-inner',

0 commit comments

Comments
 (0)