Skip to content

Commit 55bf380

Browse files
sadpandajoeclaude
andcommitted
fix(ci): opt showtime checkout into fork-PR code fetch under checkout v7
actions/checkout v7.0.0 (#41358) refuses to check out fork PR code from a pull_request_target workflow unless the step sets allow-unsafe-pr-checkout: true, which broke every showtime launch on fork PRs. The checkout is already gated behind the maintainer-authorization step (write/admin actors only) and uses persist-credentials: false, so opt in explicitly and fix the stale zizmor comment that claimed the workflow never checks out PR code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 393adc4 commit 55bf380

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/showtime-trigger.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ name: 🎪 Superset Showtime
22

33
# Ultra-simple: just sync on any PR state change
44
on:
5-
# zizmor: ignore[dangerous-triggers] - required to react to PR label changes; this workflow does not check out or execute PR-provided code
5+
# zizmor: ignore[dangerous-triggers] - required to react to PR label changes; PR code is
6+
# only checked out and built after the maintainer-authorization gate (write/admin actors)
67
pull_request_target:
78
types: [labeled, unlabeled, synchronize, closed]
89

@@ -156,6 +157,10 @@ jobs:
156157
with:
157158
ref: ${{ steps.check.outputs.target_sha }}
158159
persist-credentials: false
160+
# Building fork PR code is Showtime's purpose: deploys are gated on the
161+
# maintainer-authorization step above (write/admin actors only), so this
162+
# checkout is an explicit, authorized opt-in rather than an automatic one.
163+
allow-unsafe-pr-checkout: true
159164

160165
- name: Setup Docker Environment (only if build needed)
161166
if: steps.auth.outputs.authorized == 'true' && steps.check.outputs.build_needed == 'true'

0 commit comments

Comments
 (0)