test(navbar): assert down-chevron icon identity on navbar dropdowns

RightMenu.test.tsx and useThemeMenuItems.test.tsx passed regardless of
whether the caret used Icons.DownOutlined or Icons.CaretDownOutlined,
so the earlier regression (and this fix) went uncaught. Add a
data-icon/anticon-down assertion for each of the four dropdown call
sites (Menu, RightMenu x2, useThemeMenuItems, LanguagePicker) so a
future icon swap fails the suite instead of only being caught visually.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: sadpandajoe

superset-frontend/src/features/home/LanguagePicker.test.tsx

@@ -67,3 +67,13 @@ test('should render the items', async () => {
   expect(await screen.findByText('English')).toBeInTheDocument();
   expect(await screen.findByText('Italian')).toBeInTheDocument();
 });
+
+test('renders the down-chevron caret icon, not the caret glyph (regression #43531)', async () => {
+  render(<TestLanguagePicker {...mockedProps} />, {
+    useRouter: true,
+  });
+  const menuItem = await screen.findByRole('menuitem');
+  const caret = menuItem.querySelector('.ant-menu-item-icon');
+  expect(caret).toHaveClass('anticon-down');
+  expect(caret?.querySelector('svg')).toHaveAttribute('data-icon', 'down');
+});

superset-frontend/src/features/home/Menu.test.tsx

@@ -387,6 +387,20 @@ test('should render all the top navbar menu items', async () => {
   });
 });
 
+test('renders the down-chevron caret icon on top-level category dropdowns, not the caret glyph (regression #43531)', async () => {
+  useSelectorMock.mockReturnValue({ roles: user.roles });
+  render(<Menu {...mockedProps} />, {
+    useRedux: true,
+    useQueryParams: true,
+    useRouter: true,
+    useTheme: true,
+  });
+  const sources = await screen.findByText('Sources');
+  const caret = sources.closest('li')?.querySelector('.ant-menu-item-icon');
+  expect(caret).toHaveClass('anticon-down');
+  expect(caret?.querySelector('svg')).toHaveAttribute('data-icon', 'down');
+});
+
 test('should render the top navbar child menu items', async () => {
   useSelectorMock.mockReturnValue({ roles: user.roles });
   const {

superset-frontend/src/features/home/RightMenu.test.tsx

@@ -384,6 +384,34 @@ test('If there is NOT a DB with allow_file_upload set as True the option should
   );
 });
 
+test('renders the down-chevron caret icon on the "+" and Settings dropdowns, not the caret glyph (regression #43531)', async () => {
+  const mockedProps = createProps();
+  resetUseSelectorMock();
+  render(<RightMenu {...mockedProps} />, {
+    useRedux: true,
+    useQueryParams: true,
+    useRouter: true,
+    useTheme: true,
+  });
+
+  const newDropdownIcon = screen.getByTestId('new-dropdown-icon');
+  const newCaret = newDropdownIcon
+    .closest('li')
+    ?.querySelector('.ant-menu-item-icon');
+  expect(newCaret).toHaveClass('anticon-down');
+  expect(newCaret?.querySelector('svg')).toHaveAttribute('data-icon', 'down');
+
+  const settings = await screen.findByText(/Settings/i);
+  const settingsCaret = settings
+    .closest('li')
+    ?.querySelector('.ant-menu-item-icon');
+  expect(settingsCaret).toHaveClass('anticon-down');
+  expect(settingsCaret?.querySelector('svg')).toHaveAttribute(
+    'data-icon',
+    'down',
+  );
+});
+
 test('Logs out and clears local storage item redux', async () => {
   const mockedProps = createProps();
   resetUseSelectorMock();

superset-frontend/src/hooks/useThemeMenuItems.test.tsx

@@ -271,4 +271,14 @@ describe('useThemeMenuItems', () => {
 
     expect(divider).toBeNull();
   });
+
+  test('renders the down-chevron caret icon, not the caret glyph (regression #43531)', async () => {
+    renderThemeMenu();
+
+    const menuItem = await screen.findByRole('menuitem');
+    const caret = menuItem.querySelector('.ant-menu-item-icon');
+
+    expect(caret).toHaveClass('anticon-down');
+    expect(caret?.querySelector('svg')).toHaveAttribute('data-icon', 'down');
+  });
 });