fix(themes): add importer as editor when importing a new theme

Mirror CreateThemeCommand and the dashboard/chart/dataset importers so a
non-admin who imports a new theme can still edit/delete it (the new
editorship checks require editorship, which import previously never set).

Author: yousoph

superset/commands/theme/import_themes.py

@@ -70,10 +70,17 @@ def import_theme(config: dict[str, Any], overwrite: bool = False) -> "Theme | No
     if theme.id is None:
         db.session.flush()
 
-    # Add current user as owner if creating new theme
+    # Add current user as owner + editor when creating a new theme, mirroring
+    # CreateThemeCommand and the dashboard/chart/dataset importers, so the
+    # importer can maintain (edit/delete) the theme they just created.
     if not existing and user:
+        from superset.subjects.utils import get_user_subject
+
         theme.changed_by = user
         theme.created_by = user
+        subj = get_user_subject(user.id)
+        if subj and subj not in theme.editors:
+            theme.editors.append(subj)
 
     return theme
 

tests/integration_tests/themes/api_tests.py

@@ -459,6 +459,11 @@ def test_import_theme(self):
         theme = db.session.query(Theme).filter_by(uuid=theme_config["uuid"]).one()
         assert theme.theme_name == "imported_theme"
 
+        # The importer is added as an editor so they can maintain the new theme
+        # (mirrors CreateThemeCommand and the dashboard/chart/dataset importers).
+        admin = self.get_user(ADMIN_USERNAME)
+        assert any(editor.user_id == admin.id for editor in theme.editors)
+
         # Cleanup
         db.session.delete(theme)
         db.session.commit()