Commit f4a5010
committed
fix(pivot-table): correct expected combination order in percent_total pruning test
buildGroupbyCombinations iterates rows as the outer loop and columns as
the inner loop, so when both the rows-collapsed and columns-collapsed
levels are pruned in (the percent_total case), the rows-collapsed
level pairs with every column prefix before the leaf row prefix does
-- matching the row/col-only pruning tests directly above it. The new
percent_total test had those two entries swapped; order carries no
functional meaning downstream (transformProps/PivotData key off each
row's own tags, not array position), so this fixes the expectation
rather than the (correct) production code.1 parent 490356d commit f4a5010
1 file changed
Lines changed: 4 additions & 1 deletion
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
410 | 413 | | |
411 | 414 | | |
412 | | - | |
413 | 415 | | |
| 416 | + | |
414 | 417 | | |
415 | 418 | | |
416 | 419 | | |
| |||
0 commit comments