Redis password no longer loaded from REDIS_PASSWORD env var
#43172
Replies: 5 comments 1 reply
|
Hi @MiniaczQ! I'm Dosu and I'm helping the Apache Superset team. This isn't a bug in the Helm chart itself — the base The The fix is to use GLOBAL_ASYNC_QUERIES_CACHE_BACKEND = {
"CACHE_TYPE": "RedisCache",
"CACHE_REDIS_HOST": env("REDIS_HOST"),
"CACHE_REDIS_PORT": int(env("REDIS_PORT", "6379")),
"CACHE_REDIS_PASSWORD": env("REDIS_PASSWORD", ""),
...
}
GLOBAL_ASYNC_QUERIES_RESULTS_BACKEND = {
"backend": "redis",
"host": env("REDIS_HOST"),
"port": int(env("REDIS_PORT", "6379")),
"password": env("REDIS_PASSWORD", ""),
...
}The To reply, just mention @dosu. Docs are dead. Just use Dosu. |
|
Here is the snippet that creates the Python config: the password gets quoted which means I cannot overwrite it with arbitrary code which loads env vars |
|
@MiniaczQ Looking at the current chart's However, the current chart already provides a workaround: configOverrides:
redis_backends: |
RESULTS_BACKEND = RedisCache(
host=env('REDIS_HOST'),
password=env('REDIS_PASSWORD'),
port=env('REDIS_PORT'),
key_prefix='superset_results',
)This keeps the password out of the rendered Secret entirely — Worth noting: PR #41777 (merged, chart bumped to 0.20.0) restructures how the config is rendered with a new structured values schema, which may give you more flexibility going forward [3]. To reply, just mention @dosu. Share context across your team and agents. Try Dosu. |
|
Sounds like this isn't an issue so going to move this over to a discussion. Feel free to continue there. |
|
One can argue that you can overwrite anything in Wheteher you agree with the statement above, the fact is |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Bug description
I'm migrating from 0.15.2/5.0.0 to 0.22.4/6.1.0.
The most glaring issue is how sometimes
REDIS_PASSWORDenv var is used insuperset_config.py, but other times the password is inserted as plaintext.In 0.15.2:
both load the password from environment.
In 0.22.4:
the first part is correct, while the second inserts my placeholder
from-secretphrase.Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
3.11
Node version
16
Browser
Chrome
Additional context
No response
Checklist
All reactions