[sql_lab]Display Rows Returned / Clarify when LIMIT is reached

[eschutho]

Is your feature request related to a problem? Please describe.

• Users can't easily understand how many rows their query returned
• Users can't easily tell when the SQL Lab LIMIT is reached, so they don't know if they are only seeing a partial result set. This leads to users accidentally exporting partial datasets to CSVs

Describe the solution you'd like
Show rows returned in south pane of sql lab when they run a search

(https://www.figma.com/file/5db2MpaKNnC1c7MK9ysdeV/SQL-Limit-Indicator?node-id=90%3A71)

[eschutho]

@yousoph @Steejay can you help with designs?

[junlincc]

@eschutho
thanks for filing the issues, could you please follow the label guideline below, and use [sql_lab] as issue prefix, thanks!

_As you might have noticed, all labels(212 total) are now specified with prefix and color-coded by types and product area.
By tagging the right labels, you can help us more efficiently sort, identify and prioritize issues, questions, and PRs, ultimately helping us build a better product for the community!

https://github.com/apache/incubator-superset/labels?page=5&sort=name-asc

Here are some labels applying rules we recommend the community to follow -
select one label describing the product area (e.g. install:dependencies, viz:explore:savemodal, viz:chart-nightingale)
if you are reporting a bug, select a label describing the specific type of bug (cosmetic, performance, regression)
if you are using the enhancement request, use enhancement: committed to indicate you are working on this request, otherwise use enhancement: request
if you are working on a raised issue that needs more details or other inputs, etc., use the label starting with need: (e.g., need: screenshot)
some labels are 'reserved' for a small group of people who actively maintain the repo and direct resources. 1. assigned:_____ 2. attn:blocking and attn:rush 3. P0, P1, P2_

[eschutho]

@eschutho
thanks for filing the issues, could you please follow the label guideline below, and use [sql_lab] as issue prefix, thanks!

_As you might have noticed, all labels(212 total) are now specified with prefix and color-coded by types and product area.
By tagging the right labels, you can help us more efficiently sort, identify and prioritize issues, questions, and PRs, ultimately helping us build a better product for the community!

https://github.com/apache/incubator-superset/labels?page=5&sort=name-asc

Here are some labels applying rules we recommend the community to follow -
select one label describing the product area (e.g. install:dependencies, viz:explore:savemodal, viz:chart-nightingale)
if you are reporting a bug, select a label describing the specific type of bug (cosmetic, performance, regression)
if you are using the enhancement request, use enhancement: committed to indicate you are working on this request, otherwise use enhancement: request
if you are working on a raised issue that needs more details or other inputs, etc., use the label starting with need: (e.g., need: screenshot)
some labels are 'reserved' for a small group of people who actively maintain the repo and direct resources. 1. assigned:_____ 2. attn:blocking and attn:rush 3. P0, P1, P2_

@junlincc I don't have access to create labels, but thanks for the heads up. Are you proposing an issue prefix in addition to the label? If so, maybe we can mention that in the issue template. That could help guide people.

[junlincc]

agree! will get to it soon! @eschutho

[Steejay]

wanted to share this mockup here that shows a row returned indicator with additional info upon hover. I positioned the indicator under the results tab since it has a direct relationship with the result table.

The indicator displays w a success check icon when the row returned matches the limit dropdown or the limit specified in the query w a tooltip that adds context.

The indicator displays with a warning icon when the row returned does not match the limit dropdown w a tooltip that describes why. ie "The number of rows displayed is limited by the flag DISPLAY_MAX_ROWS = 1000".

cc @yousoph @tooptoop4 @himanshpal @ramyarajasekaran @mihir174

[tooptoop4]

@Steejay if less rows than limit returned does it show the number returned?

[Steejay]

@tooptoop4 yes. anytime a query runs successfully there will always be a row returned indicator. here is another exploration that exposes the copy so that it does not rely on hover and hopefully simplifies the logic a little more.

row indicator shows anytime a query successfully runs
warning shows anytime the result is limited from the server side (config)
message shows anytime the result is limited by something from Superset (config, limit dropdown, query)

cc @yousoph

[yousoph]

Thanks @Steejay ! I like the indicator + messages in the second exploration you shared

cc @zuzana-vej as well, this is related to #10330 that you raised