Skip to content

[Dashboard] Removing empty top level tabs crashes the dashboard builder #12959

@ktmud

Description

@ktmud

Expected results

When removing empty top-level tab, the page should not crash

Actual results

top-level-tabs.mp4

There are a couple of bugs or inconveniences related to adding tabs in dashboard builder:

  1. Adding top level tab does not have proper drop indicator
  2. Collapsing the top level tab makes the whole page crush if you have deleted the all tabs in it
  3. Deleting the last tab collapses the tab container to a weird-looking state. We should probably either redesign it or just disabling deleting the last tab

How to reproduce the bug

  1. Try add a top-level tab

Environment

Latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions