fix(explore): add margin to the adhoc filter value select

[suddjian]

SUMMARY

There wasn't any margin, so when the filter values took up >= 3 lines, the gap disappeared. Now it doesn't.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14679 (96aa17f) into master (2320bd4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #14679      +/-   ##
==========================================
- Coverage   77.55%   77.55%   -0.01%     
==========================================
  Files         958      958              
  Lines       48550    48551       +1     
  Branches     5703     5703              
==========================================
- Hits        37654    37652       -2     
- Misses      10696    10699       +3     
  Partials      200      200              

Flag	Coverage Δ
hive	81.11% <ø> (ø)
javascript	72.52% <0.00%> (-0.01%)	⬇️
mysql	81.38% <ø> (ø)
postgres	81.40% <ø> (ø)
presto	81.10% <ø> (-0.01%)	⬇️
python	81.93% <ø> (-0.01%)	⬇️
sqlite	81.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...l/AdhocFilterEditPopoverSimpleTabContent/index.jsx	77.12% <0.00%> (-0.51%)	⬇️
superset/db_engine_specs/presto.py	89.89% <0.00%> (-0.43%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2320bd4...96aa17f. Read the comment docs.

[suddjian]

I was torn on whether to go with gridUnit * 3 or gridUnit * 4 🤷

[suddjian]

Related issue: #14570

[junlincc]

/testenv up

[github-actions]

@junlincc Ephemeral environment spinning up at http://54.214.220.163:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[rusackas]

I was torn on whether to go with gridUnit * 3 or gridUnit * 4 🤷

You went with gridUnit in general, and that makes me happy in and of itself.

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://35.166.224.14:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[rusackas]

The ABC icon lost some margin or padding - not sure if that came from this PR somehow, or some other commit that came along for the ride.

[suddjian]

/testenv up

[github-actions]

@suddjian Ephemeral environment spinning up at http://54.245.202.124:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[junlincc]

i think that's due to the icon migration work. it got lost at least few days ago. notrelated to this pr

[suddjian]

Yes, the issue appears to exist in master as well, so not a problem with this PR.

[junlincc]

@geido Diego, do you mind taking a look at the icon issue i mentioned above? thanks!

[geido]

@geido Diego, do you mind taking a look at the icon issue i mentioned above? thanks!

Sure. I'll have a look

[geido]

@junlincc let's not jump to conclusions, please 😂 This is not related to the icon migration but to this PR #14674. I am already working on a solution. Thanks

[junlincc]

@junlincc let's not jump to conclusions, please 😂 This is not related to the icon migration but to this PR #14674. I am already working on a solution. Thanks

@geido i should have phrased it differently :) just an assumption not conclusion. please don't take it personally. thanks for the fix.

[rusackas]

LGTM!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.