-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Open
Labels
dashboard:componentRelated to the drag&drop components of the DashboardRelated to the drag&drop components of the Dashboarddashboard:editmodeRelated to te Dashboard edit modeRelated to te Dashboard edit mode
Description
Bug description
Currently, when dashboards were in edit mode, the row size grows with the largest component within it. However, it does not shrink with the largest component within it. Also, charts cannot be resized if they are directly above a column component due to the column drop target area extending beyond the column component. As a result, when a user would hover on the bottom edge or bottom-right corner of a component above the column component, they would only be able to move the column component instead of being able to vertically or diagonally resize the non-column component.
Row Shrinking
- Create some charts and a dashboard
- Open the dashboard in edit mode
- Add the charts to the same row in the dashboard
- Increase the height of one of the charts in the row. The row height increases (expected)
- Decrease the height of all of the charts in the row. The row height does not shrink to the size of the smallest chart in the row (unexpected)
Resizing Charts Above a Column
- Create some charts and a dashboard
- Open the dashboard in edit mode
- Add two charts to one row
- Add a column layout element to the row below
- Add a chart to the row below the row with the column
- Try to vertically and diagonally resize the chart that is in the first row and not directly above the column element. Chart resizes (expected)
- Repeat step 6 with the chart in the bottom row. Chart resizes (expected)
- Repeat step 6 with the chart in the first row that's directly above the column element. The resize cursors do not appear. The drop target menu for the column element display, though the user is hovering above the corner or bottom edge of the chart (unexpected).
Note: I have a bug fix for this, but I haven't opened a PR yet
Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist
- I have searched Superset docs and Slack and didn't find a solution to my problem.
- I have searched the GitHub issue tracker and didn't find a similar bug report.
- I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Metadata
Metadata
Assignees
Labels
dashboard:componentRelated to the drag&drop components of the DashboardRelated to the drag&drop components of the Dashboarddashboard:editmodeRelated to te Dashboard edit modeRelated to te Dashboard edit mode