Two tooltips for one icon

[aikawa-ohno]

Bug description

In SQL Lab, two tooltips 「Copy query link to your clipboard」and 「Copy to clipboard」 appear for a single icon.
In English, since one tooltip is hidden by the other, it’s not immediately obvious that two tooltips are displayed; however,
in other languages, the tooltips may overlap and not display correctly.

Screenshots/recordings

Superset version

master / latest-dev

Python version

3.10

Node version

I don't know

Browser

Chrome

Additional context

No response

Checklist

• I have searched Superset docs and Slack and didn't find a solution to my problem.
• I have searched the GitHub issue tracker and didn't find a similar bug report.
• I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[dosubot]

This is caused by two nested Tooltip components wrapping the same button. In ShareSqlLabQuery/index.tsx, the Button is given a tooltip prop ("Copy query link to your clipboard"), which makes the Button internally render a Tooltip. That button is then passed as copyNode to the CopyToClipboard component [1], which wraps it in a second Tooltip with its default text "Copy to clipboard" [2].

The simplest fix would be to add hideTooltip to the CopyToClipboard usage, which disables its tooltip and keeps only the more descriptive one from the Button:

<CopyToClipboard
  getText={getCopyUrl}
  wrapped={false}
  copyNode={buildButton()}
  hideTooltip
/>

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}