Bug description
What's wrong in the "docs" + UI
The misleading documentation is at: https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-handlebars/README.md and in the UI, seen in the screenshot from this PR: #31998 (comment)
It lists only four helpers. But Superset imports a bunch more from just-handlebars-helpers. In particular I used eq extensively today. I think this matters because when I had Claude Code write code for the Handlebars Template, it avoided eq because of this README.md. But then I had it check the codebase, it found that it can use eq and others.
Some AI opinion (all the rest of this is me, a human)
Claude notes in diagnosing this issue:
🤖: PR #20648 (merged July 2022) added the just-handlebars-helpers module to the plugin. Then PR #21143 partially reverted it away from just-handlebars-helpers but registered helpers from [math, html, strings, conditionals] modules inline. The just-handlebars-helpers library includes eq (strict equality ===), eqw(weak equality==), neq, neqw, lt, lte, gt, gte, not, ifx, and, or, coalesce, and includes` among others.
Proposed fix
Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
Not applicable
Node version
Not applicable
Browser
Not applicable
Additional context
No response
Checklist
Bug description
What's wrong in the "docs" + UI
The misleading documentation is at: https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-handlebars/README.md and in the UI, seen in the screenshot from this PR: #31998 (comment)
It lists only four helpers. But Superset imports a bunch more from
just-handlebars-helpers. In particular I usedeqextensively today. I think this matters because when I had Claude Code write code for the Handlebars Template, it avoidedeqbecause of this README.md. But then I had it check the codebase, it found that it can useeqand others.Some AI opinion (all the rest of this is me, a human)
Claude notes in diagnosing this issue:
🤖: PR #20648 (merged July 2022) added the
just-handlebars-helpersmodule to the plugin. Then PR #21143 partially reverted it away fromjust-handlebars-helpersbut registered helpers from[math, html, strings, conditionals]modules inline. Thejust-handlebars-helperslibrary includeseq (strict equality===),eqw(weak equality==),neq,neqw,lt,lte,gt,gte,not,ifx,and,or,coalesce, andincludes` among others.Proposed fix
Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
Not applicable
Node version
Not applicable
Browser
Not applicable
Additional context
No response
Checklist