fix: row limit in filter box

[aspedrosa]

SUMMARY

Currently there is a hard coded row limit on FilterBox.
I added the row limit control to the filter box visualization control panel so the user can customize this limit.
However the new default limit is 50000, imposed by the control itself.

There was another pull request (#8101) that fixed this but placed the row limit within each field being filtered, but this leads to having several row limit selects.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

Suppose that the rendering of controls cover this 🤔

ADDITIONAL INFORMATION

• Has associated issue: Row Limit in Filter Box #7971
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[aspedrosa]

Closing to rerun the CI

[tooptoop4]

@villebro can this be merged?

[mistercrunch]

I think personally I prefer the approach in #8101, looks like the PR got dropped, but it should be easy to revive/update it.

Also for the record you can change the 50k default value by using a controlOverride.

[villebro]

I'd also vote for reviving #8101

[tooptoop4]

what about an unlimited option where whatever a user types, ie "Ecuador" is sent as query to to backend db --> select distinct column from table where column like '%Ecuador%' then the results of that are shown in the dropdown list? ie Ecuador Exports, Ecuador Imports, Ecuador Revenue.... Otherwise even a limit of 10million would crash browser or not cover all entries in a huge table

[mistercrunch]

There's deeper work on filters taking place as we speak that will replace the "Filter Box" with dashboard-native filters, so we probably do not want to spend too many cycles improving Filter Box

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[srinify]

Closing this PR @aspedrosa as the community momentum is focused on the new Dashboard Native Filters and slowly deprecating Filterbox 🙏