feat(explore): Execute predicate query string if set

[nikolagigic]

SUMMARY

Execute predicate query string if set to improve the filters loads performance.
#12531

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

issue-12531.mp4

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[nikolagigic]

@junlincc @eugeniamz @villebro

[villebro]

We probably need to add parenthesis here, if either of these has an OR it will break.

Suggested change

	predicate_string = "{} AND {}".format(query_obj, predicate_string)
	predicate_string = "({}) AND ({})".format(query_obj, predicate_string)

[codecov-io]

Codecov Report

Merging #12998 (fd0d1f6) into master (76c225d) will decrease coverage by 2.27%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master   #12998      +/-   ##
==========================================
- Coverage   69.14%   66.86%   -2.28%     
==========================================
  Files        1025      490     -535     
  Lines       48765    28863   -19902     
  Branches     5188        0    -5188     
==========================================
- Hits        33718    19300   -14418     
+ Misses      14913     9563    -5350     
+ Partials      134        0     -134     

Flag	Coverage Δ
cypress	?
javascript	?
python	66.86% <14.28%> (-0.76%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/viz.py	58.86% <14.28%> (-0.19%)	⬇️
superset/db_engines/hive.py	0.00% <0.00%> (-85.72%)	⬇️
superset/sql_validators/postgres.py	50.00% <0.00%> (-50.00%)	⬇️
superset/db_engine_specs/hive.py	73.84% <0.00%> (-16.93%)	⬇️
superset/dataframe.py	91.66% <0.00%> (-8.34%)	⬇️
superset/databases/commands/create.py	83.67% <0.00%> (-8.17%)	⬇️
superset/databases/commands/update.py	85.71% <0.00%> (-8.17%)	⬇️
superset/db_engine_specs/sqlite.py	90.62% <0.00%> (-6.25%)	⬇️
superset/connectors/sqla/models.py	84.55% <0.00%> (-6.00%)	⬇️
superset/dashboards/commands/update.py	83.07% <0.00%> (-5.61%)	⬇️
... and 570 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c225d...fd0d1f6. Read the comment docs.

[villebro]

The signature here doesn't seem correct, query_obj here seems to refer to the original where and be Optional[str]?

[nikolagigic]

@villebro makes sense. Thanks for the catch!

[junlincc]

@eugeniamz @ktmud requesting review to make sure this change is okay with you both.

[ktmud]

From the code it seems this only applies to FilterBox, but the screenshot shows histogram. Is it only for demonstration's purpose?

The autocomplete predicate query string is used for this dropdown:

which then calls /filter/<datasource_type>/<datasource_id>/<column> and values_for_column. I'm wondering whether we should just reuse this API for FilterBox, too?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.