Skip to content

fix: adding new strings for hard-coded translations #13514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Danielrozputynski1994 wants to merge 2 commits into from
Closed

fix: adding new strings for hard-coded translations #13514

Danielrozputynski1994 wants to merge 2 commits into from

Conversation

@Danielrozputynski1994
Copy link

@Danielrozputynski1994 Danielrozputynski1994 commented Mar 8, 2021

SUMMARY

I have detected hard-coded words and with this pull request will be fixed

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc
Copy link
Member

junlincc commented Mar 10, 2021

thanks for the contribution!
PR looks pretty low risk, let's get it through?
@pkdotson please review. 🙏

@junlincc junlincc added the new:contributor The author is a new contributor label Mar 10, 2021
@junlincc junlincc requested a review from pkdotson March 10, 2021 04:57
@junlincc junlincc added the i18n:general Related to translations label Mar 10, 2021
@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jun 11, 2021
@amitmiran137
Copy link
Member

amitmiran137 commented Jun 28, 2021

closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkdotson pkdotson Awaiting requested review from pkdotson

Assignees

No one assigned

Labels

i18n:general Related to translations inactive Inactive for >= 30 days new:contributor The author is a new contributor size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Danielrozputynski1994 @junlincc @amitmiran137