Skip to content

Conversation

@amitmiran137
Copy link
Member

SUMMARY

support for adhoc filters on the groupby options

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@amitmiran137
Copy link
Member Author

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

@amitmiran137 Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

@amitmiran137 Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #14444 (dbb7368) into master (abbf4bf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14444      +/-   ##
==========================================
- Coverage   76.99%   76.98%   -0.01%     
==========================================
  Files         955      955              
  Lines       48091    48091              
  Branches     6040     6040              
==========================================
- Hits        37027    37025       -2     
- Misses      10866    10868       +2     
  Partials      198      198              
Flag Coverage Δ
hive 80.75% <ø> (ø)
javascript 71.69% <100.00%> (ø)
mysql 81.01% <ø> (ø)
postgres 81.04% <ø> (ø)
presto 80.74% <ø> (-0.01%) ⬇️
python 81.57% <ø> (-0.01%) ⬇️
sqlite 80.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 70.34% <100.00%> (ø)
superset/db_engine_specs/presto.py 89.89% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abbf4bf...dbb7368. Read the comment docs.

@amitmiran137
Copy link
Member Author

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

@amitmiran137 Ephemeral environment spinning up at http://52.89.64.24:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@amitmiran137 amitmiran137 requested a review from nytai May 2, 2021 19:11
@amitmiran137 amitmiran137 removed the v1.2 label May 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch deleted the feat/group_by_adhoc_filters branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant