refactor: Move fields from Extra section IIII

[lyndsiWilliams]

SUMMARY

Move the existing fields from the "Extra" section to the following sections. This also includes splitting the JSON field in "Other" and the metadata_cache_timeout field into multiple fields. The extra fields now live in the following locations:

• SQL Lab

  • Enable query cost estimation (allows_virtual_table_explore)
  • Allow this database to be explored (cost_query_enabled)

• Performance

  • Metadata Cache Timeout with Schema and Table options

    metadata_cache_timeout: {
        schema_cache_timeout,
        table_cache_timeout,
    }
    

• Security

  • Schema select for uploading data (schemas_allowed_for_csv_upload)
  • Impersonate logged in user (impersonate_user)
  • Allow data upload (allow_csv_upload)

• Other

  • engine_params and metadata params (in separate json fields)
  • version

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

• ---------- BEFORE ----------

  SQL Lab
  

  Performance
  

  Security
  

  Other
  

• ---------- AFTER ----------

  SQL Lab
  

  Performance
  

  Security

  

  Other
  

TEST PLAN

1. From the "Databases" page, open the database modal by clicking either the "+ DATABASE" button or the "Edit" action button on any listed database.
2. Observe the described changes on the following tabs: SQL Lab, Performance, Security, Other

ADDITIONAL INFORMATION

• Has associated issue: Clubhouse Ticket
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[eschutho]

does css={no_margin_bottom} work here? Should be the same thing.

[eschutho]

what about the idea to store this in the db object as a string and then parse it out in the extraOptions component? So you don't have to manipulate anything here.