Skip to content

Conversation

@stellalc7
Copy link
Contributor

@stellalc7 stellalc7 commented Jul 1, 2021

SUMMARY

Only hovering over table name, and when table name is truncated - the tooltip is triggered. Rationale for choosing 30 character limit for table name is that it was the average number of characters (since it is width dependent) to trigger truncation.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
Screenshot 2021-07-01 at 11 41 21

AFTER
Screenshot 2021-07-01 at 11 40 12

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

rusackas commented Jul 1, 2021

Hey there, thanks for the PR!

If we want to avoid a hard-coded character count, and be more dynamic (so we can expand/contract the sidebar) we might be able to use an approach like this:

https://codesandbox.io/s/ant-design-conditional-tooltip-yuxx5?file=/src/index.tsx

That TooltipParagraph component could be useful in a number of places in Superset - though maybe a better name might help (TitleWithTooltip or something?).

What do you think?

@stellalc7
Copy link
Contributor Author

Sure, that sounds good - let me try it - thanks!

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 16, 2022
@stale stale bot closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inactive Inactive for >= 30 days size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants