Skip to content

Conversation

@villebro
Copy link
Member

@villebro villebro commented Aug 2, 2021

@junlincc junlincc added risk:superset-ui hold:testing! On hold for testing and removed hold:testing! On hold for testing labels Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #16033 (a5ab286) into master (5031a67) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head a5ab286 differs from pull request most recent head 2342ff9. Consider uploading reports for the commit 2342ff9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16033      +/-   ##
==========================================
- Coverage   76.83%   76.68%   -0.15%     
==========================================
  Files         995      995              
  Lines       52774    52774              
  Branches     6691     6691              
==========================================
- Hits        40549    40472      -77     
- Misses      12000    12077      +77     
  Partials      225      225              
Flag Coverage Δ
hive ?
javascript 71.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-1.05%) ⬇️
superset/db_engine_specs/base.py 87.98% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 88.00% <0.00%> (-0.25%) ⬇️
superset/utils/core.py 88.17% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5031a67...2342ff9. Read the comment docs.

@villebro villebro closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants