Skip to content

feat: Add resizing to column widths #16279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrewbastian wants to merge 29 commits into from
Closed

feat: Add resizing to column widths #16279

andrewbastian wants to merge 29 commits into from

Conversation

@andrewbastian
Copy link
Contributor

@andrewbastian andrewbastian commented Aug 16, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@andrewbastian
about to pull updated pack...jsons
6fe2124
@andrewbastian
Merge branch 'master' of https://github.com/apache/superset into sql-…
594c325 
…lab-column-resize
@andrewbastian
Merge branch 'master' of https://github.com/apache/superset into sql-…
f0a8a00 
…lab-column-resize
@andrewbastian
Working on function to create Columns object for React-Table
694c666
@andrewbastian
Merge branch 'master' of https://github.com/apache/superset into sql-…
d15e3e8 
…lab-column-resize
@andrewbastian
Merge branch 'master' of https://github.com/apache/superset into sql-…
8d07d09 
…lab-column-resize
@andrewbastian
Merge branch 'master' of https://github.com/apache/superset into sql-…
9aae4f4 
…lab-column-resize
@andrewbastian
Added function to create arr-o-objs for React-Table - It works
2d81eab
@andrewbastian
Merge branch 'master' of https://github.com/apache/superset into sql-…
b4a4a12 
…lab-column-resize
@andrewbastian
Removed un-used method and working on fixing/understanding style.
989a39e
@andrewbastian
Merge branch 'master' of https://github.com/apache/superset into sql-…
b1a1737 
…lab-column-resize
@andrewbastian
Style work on resize
e8a3f9d 
- Changed table elements to `div`s with `className` === `<tableElement>`

- Added `Flex` props to work with `react-table` - needed for
  `useResizeColumns`

  - The variables created for this need type definition for the
    arguments.

- Moved styling from ResizableTable to this component.

    - Currently trying to resolve issue with column position on resize.

    - Also need to fix:

        - Column cell boarder right missing

        - Sort icon display when sort activated

        - Header text font-weight and hover action

        - Remove resizer class from last header
@andrewbastian
Removed style and added useFlexLayout
c5b8500 
Styling has been moved to `TableDisplay.tsx`
@andrewbastian
Merge branch 'master' of https://github.com/apache/superset into sql-…
cbf6554 
…lab-column-resize

Bringing dev branch up to date with main-repository's master branch
@eschutho eschutho added the Superset-Community-Partners Preset community partner program participants label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/XXL Superset-Community-Partners Preset community partner program participants

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewbastian @eschutho @amitmiran137