Skip to content

Comments

fix: rename Databricks#16297

Merged
betodealmeida merged 1 commit intoapache:masterfrom
betodealmeida:rename_databricks
Aug 17, 2021
Merged

fix: rename Databricks#16297
betodealmeida merged 1 commit intoapache:masterfrom
betodealmeida:rename_databricks

Conversation

@betodealmeida
Copy link
Member

SUMMARY

Remove "Hive" from Databricks name, since it's an implementation detail.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh self-requested a review August 17, 2021 17:36
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #16297 (55b220d) into master (f581e04) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16297      +/-   ##
==========================================
- Coverage   76.54%   76.39%   -0.15%     
==========================================
  Files         999      999              
  Lines       53376    53376              
  Branches     6817     6817              
==========================================
- Hits        40856    40779      -77     
- Misses      12283    12360      +77     
  Partials      237      237              
Flag Coverage Δ
hive ?
mysql 81.60% <100.00%> (ø)
postgres 81.58% <100.00%> (-0.05%) ⬇️
python 81.71% <100.00%> (-0.29%) ⬇️
sqlite 81.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/databricks.py 100.00% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-1.05%) ⬇️
superset/db_engine_specs/base.py 88.00% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 88.04% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.86% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f581e04...55b220d. Read the comment docs.

@betodealmeida betodealmeida merged commit 8a36356 into apache:master Aug 17, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants