Skip to content

Conversation

@AAfghahi
Copy link
Member

SUMMARY

Antd button design disallows all cursor events when a button is disabled, which turns off our tooltips on disabled buttons. The easiest solution is outlined here: react-component/tooltip#18

Summarized, you have to wrap a disabled button in a span to show the tooltip. However, if you have a span on an enabled button then you get two tooltips. This PR wraps the button in a span if it is disabled.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-09-24.at.1.10.14.PM.mov

TESTING INSTRUCTIONS

Have the KV/store featureflag disabled in your superset_config.

Write a query, hover over the copy link to see if there is a tooltip. There should be a tooltip.
Save the query, the color should change and there should be a different tooltip.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi force-pushed the ch24579_sqlLabTooltip branch from 6b6cbb4 to 7f4a839 Compare September 24, 2021 17:18
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #16837 (e2c3385) into master (0d064f4) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head e2c3385 differs from pull request most recent head 7f4a839. Consider uploading reports for the commit 7f4a839 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16837      +/-   ##
==========================================
- Coverage   76.99%   76.79%   -0.20%     
==========================================
  Files        1018     1018              
  Lines       54674    54687      +13     
  Branches     7456     7461       +5     
==========================================
- Hits        42094    41996      -98     
- Misses      12335    12447     +112     
+ Partials      245      244       -1     
Flag Coverage Δ
hive ?
javascript 71.13% <100.00%> (+0.04%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dataMask/reducer.ts 71.15% <ø> (+5.76%) ⬆️
superset-frontend/src/components/Button/index.tsx 100.00% <100.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 88.37% <100.00%> (+2.04%) ⬆️
superset-frontend/src/dataMask/actions.ts 72.22% <100.00%> (+33.33%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
...hboard/components/nativeFilters/FilterBar/utils.ts 71.87% <0.00%> (-3.13%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 85.57% <0.00%> (-1.66%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d064f4...7f4a839. Read the comment docs.

@betodealmeida betodealmeida merged commit 04f7eca into apache:master Sep 24, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants