Skip to content

Conversation

@hughhhh
Copy link
Member

@hughhhh hughhhh commented Dec 13, 2021

SUMMARY

Adding frontend build step for make install command

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title feat: add npm install to `make install feat: add npm install to make install Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #17733 (1ebc3fb) into master (0d2299c) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17733      +/-   ##
==========================================
- Coverage   68.06%   67.95%   -0.11%     
==========================================
  Files        1653     1653              
  Lines       66374    66374              
  Branches     7121     7121              
==========================================
- Hits        45177    45104      -73     
- Misses      19300    19373      +73     
  Partials     1897     1897              
Flag Coverage Δ
hive ?
mysql 82.15% <ø> (ø)
postgres 82.20% <ø> (+0.01%) ⬆️
python 82.29% <ø> (-0.25%) ⬇️
sqlite 81.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-0.84%) ⬇️
superset/db_engine_specs/base.py 88.29% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-0.23%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️
superset/reports/commands/execute.py 91.22% <0.00%> (+0.38%) ⬆️
superset/common/query_object.py 95.62% <0.00%> (+0.54%) ⬆️
superset/commands/importers/v1/utils.py 91.30% <0.00%> (+2.17%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2299c...1ebc3fb. Read the comment docs.

@hughhhh hughhhh closed this Dec 13, 2021
@mistercrunch mistercrunch deleted the update-makefile branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant