Skip to content

Comments

Better unit tests#18645

Closed
betodealmeida wants to merge 2 commits intomasterfrom
better_unit_tests
Closed

Better unit tests#18645
betodealmeida wants to merge 2 commits intomasterfrom
better_unit_tests

Conversation

@betodealmeida
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #18645 (5a05d34) into master (8e02d11) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18645      +/-   ##
==========================================
+ Coverage   68.66%   68.92%   +0.25%     
==========================================
  Files        1596     1597       +1     
  Lines       65224    65284      +60     
  Branches     6950     6950              
==========================================
+ Hits        44789    44999     +210     
+ Misses      18550    18400     -150     
  Partials     1885     1885              
Flag Coverage Δ
javascript 57.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/key_value/commands/exceptions.py 100.00% <0.00%> (ø)
superset/dashboards/filter_state/commands/entry.py 100.00% <0.00%> (ø)
superset/utils/core.py 89.76% <0.00%> (+0.11%) ⬆️
superset/connectors/sqla/models.py 88.42% <0.00%> (+0.22%) ⬆️
superset/initialization/__init__.py 89.82% <0.00%> (+1.75%) ⬆️
superset/utils/feature_flag_manager.py 100.00% <0.00%> (+3.70%) ⬆️
superset/utils/logging_configurator.py 85.18% <0.00%> (+3.70%) ⬆️
superset/utils/cache_manager.py 100.00% <0.00%> (+3.84%) ⬆️
superset/db_engine_specs/hive.py 87.25% <0.00%> (+16.98%) ⬆️
superset/dashboards/filter_state/api.py 100.00% <0.00%> (+17.02%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e02d11...5a05d34. Read the comment docs.

@mistercrunch mistercrunch deleted the better_unit_tests branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant