Skip to content

Update clickhouse.mdx#19133

Closed
ishyesh wants to merge 1 commit intoapache:masterfrom
ishyesh:patch-1
Closed

Update clickhouse.mdx#19133
ishyesh wants to merge 1 commit intoapache:masterfrom
ishyesh:patch-1

Conversation

@ishyesh
Copy link

@ishyesh ishyesh commented Mar 12, 2022

Changed clickhouse version string for docker vs. not.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Changed clickhouse version string for docker vs. not.
@srinify
Copy link
Contributor

srinify commented Mar 14, 2022

Hey @ishyesh this is actually covered here in the 'addding new drivers' page but I think it could be made clearer. How do you feel about updating the "common" instructions here instead?: https://superset.apache.org/docs/databases/docker-add-drivers

.. And then link to it from the Clickhouse page? Adding database drivers when using Docker Compose is the same for any database after all 🤔

@srinify srinify closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants