add form_data with query #20014
Closed
add form_data with query #20014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset-github-bot
bot
added
the
Superset-Community-Partners
eschutho
commented
May 10, 2022
| contextual_key = cache_key(session.get("_id"), tab_id, dataset_id, chart_id) | ||
| check_access(datasource_id, chart_id, actor, datasource_type) | ||
| contextual_key = cache_key( | ||
| session.get("_id"), tab_id, datasource_id, chart_id |
Member
Author
There was a problem hiding this comment.
missing datasource_type here
eschutho
commented
May 10, 2022
| class CommandParameters: | ||
| actor: User | ||
| dataset_id: int = 0 | ||
| datasource_type: str |
Member
Author
There was a problem hiding this comment.
use the DatasourceType enum
eschutho
commented
May 10, 2022
| dataset_id: int | ||
| chart_id: Optional[int] | ||
| form_data: str | ||
| datasource_type: str |
Member
Author
There was a problem hiding this comment.
use DatasourceType enum
hughhhh
reviewed
May 11, 2022
| "datasource_type": "query", | ||
| } | ||
| resp = client.post("api/v1/explore/form_data", json=payload) | ||
| print(resp.data) |
hughhhh
reviewed
May 11, 2022
| datasource_type = fields.String( | ||
| description=datasource_type_description, | ||
| validate=validate.OneOf(choices=("druid", "table", "view")), | ||
| validate=validate.OneOf(choices=("druid", "table", "view", "query")), |
Member
There was a problem hiding this comment.
can we change these to be the enums as well?
hughhhh
reviewed
May 11, 2022
| docker-compose stop superset-tests-worker superset || true | ||
| RESET_DB_CMD="psql \"postgresql://${DB_USER}:${DB_PASSWORD}@127.0.0.1:5432\" <<-EOF | ||
| # docker-compose stop superset-tests-worker superset || true | ||
| psql -U ${DB_USER} |
Member
There was a problem hiding this comment.
do we want to check in these changes?
Member
Author
There was a problem hiding this comment.
no, they're just for testing
eschutho
removed
the
Superset-Community-Partners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION