Skip to content

[WIP] feat: adjust models for Oracle compatibility #20394

Closed
mgorsk1 wants to merge 3 commits intoapache:masterfrom
mgorsk1:feat/oracle_backend_support
Closed

[WIP] feat: adjust models for Oracle compatibility #20394
mgorsk1 wants to merge 3 commits intoapache:masterfrom
mgorsk1:feat/oracle_backend_support

Conversation

@mgorsk1
Copy link

@mgorsk1 mgorsk1 commented Jun 15, 2022

SUMMARY

Minor changes to make Superset compatible with Oracle as backing db.

  • fixes alembic migrations
  • renames 'rows' to 'row_count' in Query model (rows is restricted phrase in Oracle)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TESTING INSTRUCTIONS

n/a

ADDITIONAL INFORMATION

@mgorsk1 mgorsk1 changed the title feat: adjust models for Oracle compatibility [WIP] feat: adjust models for Oracle compatibility Jun 15, 2022
@rusackas
Copy link
Member

@mgorsk1 Checking in (like with other aging WIP PRs) to see if there's intent to carry this forward. 🤞 There are a good number of oracle issues so I'm curious if this might address any of them.

@rusackas rusackas closed this Feb 6, 2024
@rusackas
Copy link
Member

rusackas commented Feb 6, 2024

Let us know if you want to pick this back up, we'd love to have the contribution!

@selvadinesh
Copy link

Any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants