feat: Add Turkey map to Country Map#20587
Closed
rizacavus wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Member
|
Hi @rizacavus Thanks for the contribution! code looks great, do you mind fixing the code style to unlock the CI? |
Codecov Report
@@ Coverage Diff @@
## master #20587 +/- ##
=======================================
Coverage 66.80% 66.80%
=======================================
Files 1754 1754
Lines 65572 65572
Branches 6933 6933
=======================================
Hits 43804 43804
Misses 20014 20014
Partials 1754 1754
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
|
Closing since this already exists :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add Turkey map to Country Map.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Clone the repo and go to its root directory. Run the following shell commands:
cd superset-frontend && npm install
npm run plugins:storybook
ADDITIONAL INFORMATION