Skip to content

feat: Add Turkey map to Country Map#20587

Closed
rizacavus wants to merge 2 commits intoapache:masterfrom
rizacavus:feat--turkey-map
Closed

feat: Add Turkey map to Country Map#20587
rizacavus wants to merge 2 commits intoapache:masterfrom
rizacavus:feat--turkey-map

Conversation

@rizacavus
Copy link
Contributor

SUMMARY

Add Turkey map to Country Map.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

175822046-09a5d9b7-f781-4910-b3fb-630b384eece1

TESTING INSTRUCTIONS

Clone the repo and go to its root directory. Run the following shell commands:

cd superset-frontend && npm install
npm run plugins:storybook

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie
Copy link
Member

Hi @rizacavus Thanks for the contribution! code looks great, do you mind fixing the code style to unlock the CI?

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #20587 (9b2cbdc) into master (290b89c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20587   +/-   ##
=======================================
  Coverage   66.80%   66.80%           
=======================================
  Files        1754     1754           
  Lines       65572    65572           
  Branches     6933     6933           
=======================================
  Hits        43804    43804           
  Misses      20014    20014           
  Partials     1754     1754           
Flag Coverage Δ
javascript 51.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
...superset-ui-core/src/query/types/PostProcessing.ts 100.00% <0.00%> (ø)
...t-ui-chart-controls/src/operators/pivotOperator.ts 100.00% <0.00%> (ø)
...controls/src/operators/timeComparePivotOperator.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290b89c...9b2cbdc. Read the comment docs.

@srinify
Copy link
Contributor

srinify commented Jul 13, 2022

Closing since this already exists :)

#20698

@srinify srinify closed this Jul 13, 2022
@rizacavus rizacavus deleted the feat--turkey-map branch July 19, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants