Skip to content

feat: save dataset savemodal#20798

Closed
pkdotson wants to merge 2 commits intoapache:masterfrom
preset-io:feat-savechart-dataset-2
Closed

feat: save dataset savemodal#20798
pkdotson wants to merge 2 commits intoapache:masterfrom
preset-io:feat-savechart-dataset-2

Conversation

@pkdotson
Copy link
Member

SUMMARY

This pr allows for the dataset to be saved in the save datasetmodal in explore when dataset is type query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

write a query in sqllab and create a chart. Go to save and save the chart and dataset.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants