chore(deps): set correct version of flask_caching#21228
chore(deps): set correct version of flask_caching#21228KNOEEE wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
|
@KNOEEE did you check if it's possible to bump |
Codecov Report
@@ Coverage Diff @@
## master #21228 +/- ##
=======================================
Coverage 66.40% 66.40%
=======================================
Files 1783 1783
Lines 68087 68087
Branches 7261 7261
=======================================
Hits 45215 45215
Misses 21007 21007
Partials 1865 1865
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
No, I didn't. Maybe I can try it. If it's all good, we should set deps as |
|
I'd prefer to bump the full chain of deps if it's possible, i.e. |
|
Closing this since it seems like we're on |
SUMMARY
We need to set the highest version of flask-caching lower than v2.0.0, because it need "cachelib >= 0.9.0" since v2.0 which is not compatible with requirements of superset("cachelib>=0.4.1,<0.5").
Ref: https://github.com/pallets-eco/flask-caching/blob/v2.0.0/setup.py
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
It failed down if building with flask-caching2.0.0+.
ADDITIONAL INFORMATION