Skip to content

[WIP]fix: regression in the from_dttm and to_dttm#22078

Closed
zhaoyongjie wants to merge 1 commit intoapache:masterfrom
zhaoyongjie:fix_temporal_column_in_template
Closed

[WIP]fix: regression in the from_dttm and to_dttm#22078
zhaoyongjie wants to merge 1 commit intoapache:masterfrom
zhaoyongjie:fix_temporal_column_in_template

Conversation

@zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Nov 9, 2022

SUMMARY

TBD, fix a regression in the from_dttm and to_dttm in the jinja template. I will add more description after CI passed because I need to check which UT/IT will be affected by this change.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #22078 (772552e) into master (4496748) will decrease coverage by 11.33%.
The diff coverage is 100.00%.

❗ Current head 772552e differs from pull request most recent head 3851562. Consider uploading reports for the commit 3851562 to get more accurate results

@@             Coverage Diff             @@
##           master   #22078       +/-   ##
===========================================
- Coverage   67.12%   55.78%   -11.34%     
===========================================
  Files        1818     1818               
  Lines       69639    69639               
  Branches     7496     7496               
===========================================
- Hits        46747    38851     -7896     
- Misses      20954    28850     +7896     
  Partials     1938     1938               
Flag Coverage Δ
hive 52.84% <100.00%> (+<0.01%) ⬆️
mysql ?
postgres ?
presto 52.74% <100.00%> (+<0.01%) ⬆️
python 58.02% <100.00%> (-23.55%) ⬇️
sqlite ?
unit 51.19% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/query_object_factory.py 86.48% <100.00%> (-5.41%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/tags/core.py 4.54% <0.00%> (-95.46%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-90.91%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-87.88%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-84.00%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/create.py 30.61% <0.00%> (-69.39%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-69.00%) ⬇️
... and 285 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant