chore: chart deletion test for slice user#22703
Closed
Conversation
cd458d5 to
825488b
Compare
Codecov Report
@@ Coverage Diff @@
## master #22703 +/- ##
===========================================
- Coverage 67.02% 53.73% -13.30%
===========================================
Files 1859 1866 +7
Lines 71036 75039 +4003
Branches 7766 7766
===========================================
- Hits 47612 40320 -7292
- Misses 21401 32697 +11296
+ Partials 2023 2022 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
825488b to
eff3e2a
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some users were experiencing an foreign key error when trying to delete a chart or a dashboard for slice_user and sqlatable_user. Just adding some test to makes sure those possibilities are taken into account.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION