Skip to content

test pyhive sqlalchemy 2 changes#24163

Closed
mdeshmu wants to merge 1 commit into
apache:masterfrom
mdeshmu:test-sqlalchemy-2.0-pyhive
Closed

test pyhive sqlalchemy 2 changes#24163
mdeshmu wants to merge 1 commit into
apache:masterfrom
mdeshmu:test-sqlalchemy-2.0-pyhive

Conversation

@mdeshmu
Copy link
Copy Markdown
Contributor

@mdeshmu mdeshmu commented May 22, 2023

SUMMARY

test pyhive sqlalchemy 2 changes from dropbox/PyHive#455

Trying to identify effort needed for migration from sqlalchemy 1.4.x to 2.x

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2023

Codecov Report

Merging #24163 (5dddcca) into master (febc07a) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 5dddcca differs from pull request most recent head 9a47924. Consider uploading reports for the commit 9a47924 to get more accurate results

@@            Coverage Diff             @@
##           master   #24163      +/-   ##
==========================================
- Coverage   68.27%   68.26%   -0.01%     
==========================================
  Files        1952     1952              
  Lines       75369    75369              
  Branches     8210     8210              
==========================================
- Hits        51457    51454       -3     
- Misses      21806    21809       +3     
  Partials     2106     2106              
Flag Coverage Δ
hive 53.30% <ø> (-0.01%) ⬇️
mysql 78.94% <ø> (-0.01%) ⬇️
postgres 79.01% <ø> (-0.02%) ⬇️
presto 53.22% <ø> (-0.01%) ⬇️
python 82.82% <ø> (-0.01%) ⬇️
sqlite 77.55% <ø> (-0.01%) ⬇️
unit 53.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley
Copy link
Copy Markdown
Member

@mdeshmu could you provide a more detailed PR description so reviewers can better understand the intent?

@mdeshmu
Copy link
Copy Markdown
Contributor Author

mdeshmu commented May 22, 2023

@john-bodley sorry for inconvenience. Added the summary.

There are lots of changes as per https://docs.sqlalchemy.org/en/20/changelog/migration_20.html and keeping compatibility with both sqlalchemy versions is a lot of work and may take time. I gave a shot at fixing imports and ran test cases in PyHive with SQLAlchemy 2.0. Coverage went down to less than 40% due to various depredations in 2.0x

I am closing this PR since sqlalchemy 2.0 support might not come to superset until next year. Will revisit in future.

@mdeshmu mdeshmu closed this May 22, 2023
@mdeshmu mdeshmu deleted the test-sqlalchemy-2.0-pyhive branch May 22, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants