test pyhive sqlalchemy 2 changes#24163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24163 +/- ##
==========================================
- Coverage 68.27% 68.26% -0.01%
==========================================
Files 1952 1952
Lines 75369 75369
Branches 8210 8210
==========================================
- Hits 51457 51454 -3
- Misses 21806 21809 +3
Partials 2106 2106
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@mdeshmu could you provide a more detailed PR description so reviewers can better understand the intent? |
|
@john-bodley sorry for inconvenience. Added the summary. There are lots of changes as per https://docs.sqlalchemy.org/en/20/changelog/migration_20.html and keeping compatibility with both sqlalchemy versions is a lot of work and may take time. I gave a shot at fixing imports and ran test cases in PyHive with SQLAlchemy 2.0. Coverage went down to less than 40% due to various depredations in 2.0x I am closing this PR since sqlalchemy 2.0 support might not come to superset until next year. Will revisit in future. |
SUMMARY
test pyhive sqlalchemy 2 changes from dropbox/PyHive#455
Trying to identify effort needed for migration from sqlalchemy 1.4.x to 2.x
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION